Completed w1d2 programming project#28
Open
mikeflow22 wants to merge 5 commits intobloominstituteoftechnology:masterfrom
Open
Completed w1d2 programming project#28mikeflow22 wants to merge 5 commits intobloominstituteoftechnology:masterfrom
mikeflow22 wants to merge 5 commits intobloominstituteoftechnology:masterfrom
Conversation
…l controller file.
|
Michael, great job on the project! The functionality is there. The add and remove functions work properly. The MVC architecture is there. I like the comments you added for each method or property, something that is overlooked for sure. A like the amount of commits you had. Keep that up. The organization by putting things into files is a must and something I like to see! My suggestions would be to work on your constraints and add all your UI objects in a stack view. Also, maybe try implementing this by switching the "String" type for the items array to "Item". Overall, awesome work! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, I have completed the daily programming challenge.