List App Completed.#35
Open
sdoylelambda wants to merge 8 commits intobloominstituteoftechnology:masterfrom
Open
List App Completed.#35sdoylelambda wants to merge 8 commits intobloominstituteoftechnology:masterfrom
sdoylelambda wants to merge 8 commits intobloominstituteoftechnology:masterfrom
Conversation
…and displaying user notes.
… Print button is clicked on app.
ilqarilyasov
left a comment
ilqarilyasov
left a comment
There was a problem hiding this comment.
Great job Sean! Your app works flawless.
I see that you strongly follow Erica's pattern :) which is very nice. You have a clean code, perfect storyboard. You made good amount of commits but I would suggest you use present tense in your commit messages. And also please read more about concepts and try to write a good, not short answer for the questions. Overall good work, man!
Author
|
Thanks Ilqar!
I will work on using present tense for my commit messages and expand on my
answers.
See you tomorrow!
…On Wed, Jan 9, 2019, 9:02 PM ilqar ilyasov ***@***.***> wrote:
***@***.**** commented on this pull request.
Great job Sean! Your app works flawless.
I see that you strongly follow Erica's pattern :) which is very nice. You
have a clean code, perfect storyboard. You made good amount of commits but
I would suggest you use present tense in your commit messages. And also
please read more about concepts and try to write a good, not short answer
for the questions. Overall good work, man!
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#35 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ApC4HkF216hiUVcpknSqW5ys3Ht4IzJ8ks5vBpYKgaJpZM4Z2hJP>
.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One stretch goal done so far.
@ilqarilyasov