Andre Myrick - Processes & System Calls

[AM-Myrick]

No description provided.

[codejoncode]

You have some good looking stuff here. I would only recommend the following if statement,

if (rc < 0) {
        fprintf(stderr, "fork failed\n");
        exit(1);
    }

/*stderr is the standard error stream the default destination for error messages and other diagnostic warnings. Like stdout 
      it is usually also directed by default to the text console(generally, on the screen). 
      */
exit   so its prototype looks like this 
      void exit(int status);
      Returns nothing   but indicates whehter the program terminated normally.  
      exit_success   successful termination 
      0    successful termination 
      exit_failure   unsuccessful termination 

      exit will terminate the program and everything that comes after it will not show up. 

This is for ex1.c but anytime you use fork() you should be prepared for if there is an error or interruption.

[codejoncode]

For ex4 we want to set up the main to accept argc and argv[] this would be entered in on the command line and read into the program and then worked with accordingly. Your code may infact generate the correct output but you may see functions where main will be prepared to accept arguments so I wanted to show you this.

int main(int argc, char* argv[])
{
    printf("Parent process here\n");
    int rc = fork();

    if (rc < 0) {
        fprintf(stderr, "fork failed\n");
        exit(1);
    } else if (rc == 0) {
        printf("Child process here\n");

        // execl("/bin/ls", "ls", "-l" (char *) NULL);
        
        // char *args[] = {"ls", "-l", NULL};
        // execv("/bin/ls", args);

        //execlp("ls", "ls", "-l", (char *) NULL);

        char *args[] = {"ls", "-l", NULL};
        execvp("ls", args);
    } else {
        int wc = waitpid(rc, NULL, 0);
    }

    return 0;
}

This way we would then pass "/bin/ls"

[codejoncode]

The biggest difference is we could replace char *args[] = {"ls", "-l", NULL}; with your char * argv[] main argument for comment on ex4.

[codejoncode]

This looks good Andre, before we read as a best practice lets close(p[1] where we wrote to. in between read and writes we want to close the opposite.