implemented app basic functionality#10
Open
audreywelch wants to merge 1 commit intobloominstituteoftechnology:masterfrom
audreywelch:master
Open
implemented app basic functionality#10audreywelch wants to merge 1 commit intobloominstituteoftechnology:masterfrom audreywelch:master
audreywelch wants to merge 1 commit intobloominstituteoftechnology:masterfrom
audreywelch:master
Conversation
|
Looks good! Seems like you've got all the required features. Just make sure you answer the questions in the future. You can put them in an empty .txt or .md file inside of your project. Also, you will probably want to set up your global git ignore file, that will make your commits a little cleaner, and make it easier for the PMs to review your code. I think Erica covers it here: https://www.youtube.com/watch?v=0fzNSluYjNM |
Author
|
Hmmm, I thought I did set up my global git ignore file last week when
following along with this video. Maybe I will try again.
And I sent the .txt file with the answers to the questions directly to my
PM - I will try to put it inside my project this time. Thanks!
…On Tue, Nov 6, 2018 at 11:27 AM Dillon McElhinney ***@***.***> wrote:
Looks good! Seems like you've got all the required features. Just make
sure you answer the questions in the future. You can put them in an empty
.txt or .md file inside of your project.
Also, you will probably want to set up your global git ignore file, that
will make your commits a little cleaner, and make it easier for the PMs to
review your code. I think Erica covers it here:
https://www.youtube.com/watch?v=0fzNSluYjNM
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#10 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AZW-1vWzdDkKEpGnpyOIolIMiqu6b8Dhks5usbhkgaJpZM4YPi-Q>
.
|
|
No worries on the git ignore file. I may have misread the file history. Perfect! If you'd like you can do both. I'm not sure how each PM wants to get those. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added functionality of red dot appearing when user taps the screen.