Sprites #13
Open
arielmclaughlinn wants to merge 6 commits intobloominstituteoftechnology:masterfrom
arielmclaughlinn:master
Open
Sprites #13arielmclaughlinn wants to merge 6 commits intobloominstituteoftechnology:masterfrom arielmclaughlinn:master
arielmclaughlinn wants to merge 6 commits intobloominstituteoftechnology:masterfrom
arielmclaughlinn:master
Conversation
Now generates random colors
Now generated random colors
|
Looks good Ariel! You have all the required features and got the random color stretch goal. You may want to get rid of line 25 in CustomScene.swift, because you aren't actually using it and it is giving you a compile warning. I also noticed that you generated a random Float and then converted that to a CGFloat for your colors. CGFloat also has a .random() method, so you could use that to simplify a little bit. Also, make sure you answer the questions in the README for each day's project. You can include them in a .txt or a .md file inside of your project. (Forgive me if you did submit it and I'm just not seeing it.) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@jasonmodisett17