Sprites 11.13#18
Open
sdoylelambda wants to merge 7 commits intobloominstituteoftechnology:masterfrom
sdoylelambda:master
Open
Sprites 11.13#18sdoylelambda wants to merge 7 commits intobloominstituteoftechnology:masterfrom sdoylelambda:master
sdoylelambda wants to merge 7 commits intobloominstituteoftechnology:masterfrom
sdoylelambda:master
Conversation
|
Code looks good Sean. You've definitely got the required features. I would like to see you push into the stretch goals a little bit, especially since you got done so fast. Also, I didn't see the questions anywhere. Were those in your pull request? |
Author
|
Thanks Dillon, I'm almost finished with the List app. I'll add answers to
the questions, then work on stretch goals.
…On Tue, Nov 13, 2018, 5:45 PM Dillon McElhinney ***@***.***> wrote:
Code looks good Sean. You've definitely got the required features. I would
like to see you push into the stretch goals a little bit, especially since
you got done so fast. Also, I didn't see the questions anywhere. Were those
in your pull request?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#18 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ApC4HidP5MYaSLqNRoyAnoIl_NSJ1rMYks5uu0ucgaJpZM4Ycnam>
.
|
|
Thanks Sean! Looks good. |
Author
|
Great, thanks!
…On Tue, Nov 13, 2018, 6:47 PM Dillon McElhinney ***@***.***> wrote:
Thanks Sean! Looks good.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#18 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ApC4Hnovyj7vGLQYiq7f4J_OWRbdspg_ks5uu1oCgaJpZM4Ycnam>
.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@dillon-mce