-
Notifications
You must be signed in to change notification settings - Fork 1
Feature/update devcontainer #107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reviewer's guide (collapsed on small PRs)Reviewer's GuideUpdates the development container to parameterize the Pixi version via build arguments and aligns the Pixi lockfile and devcontainer configuration with this change. Flow diagram for devcontainer build with parameterized Pixi versionflowchart TD
A[Start devcontainer build] --> B[Set build arg PIXI_VERSION]
B --> C[Docker builds from .devcontainer/Dockerfile]
C --> D[Dockerfile uses PIXI_VERSION in curl URL]
D --> E[Download Pixi binary for target architecture]
E --> F[Install Pixi to /usr/local/bin/pixi]
F --> G[Devcontainer image built]
G --> H[Devcontainer started in VS Code]
H --> I[Pixi version inside container matches PIXI_VERSION arg]
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey - I've found 1 issue
Prompt for AI Agents
Please address the comments from this code review:
## Individual Comments
### Comment 1
<location> `.devcontainer/Dockerfile:3` </location>
<code_context>
FROM mcr.microsoft.com/devcontainers/base:jammy
-ARG PIXI_VERSION=v0.48.2
+ARG PIXI_VERSION
RUN curl -L -o /usr/local/bin/pixi -fsSL --compressed "https://github.com/prefix-dev/pixi/releases/download/${PIXI_VERSION}/pixi-$(uname -m)-unknown-linux-musl" \
</code_context>
<issue_to_address>
**issue (bug_risk):** Consider providing a default or validating PIXI_VERSION to avoid fragile builds.
Without a default, builds will fail whenever `PIXI_VERSION` isn’t provided. If that’s intentional, consider either keeping a sensible default or adding a simple guard (e.g., a non-empty `PIXI_VERSION` check that fails with a clear error) to make failures easier to diagnose and to avoid unexpected CI/devcontainer breakage when the arg is omitted.
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary by Sourcery
Build: