Merged
Conversation
Lint configuration is too old, cannot catch recent standard TS rules. It leads unexpected code changes that breaks build/valid lint stage. Disable temporarily until finding valid lint configuration.
Introduce dynamic brand color change for those who want to use own color across the whole pages. This doesn't break original design/color palette that papercups had sticked. By putting env variable `REACT_APP_BRAND_COLOR`(hex code), can change default app primary color.
tinyjin
force-pushed
the
jinny/brand-color-change
branch
from
d6e617e to
140971d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Introduce dynamic brand color change for those who want to use own color across the whole pages.
This doesn't break original design/color palette that papercups had sticked.
By putting env variable
REACT_APP_BRAND_COLOR(hex code), can change default app primary color.Issue
Link to the issue (if available)
Screenshots
Checklist
mix testmix format