Updated packages and other changes. #33
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The program wasn't loading the MangaOCR model and it seems others were having the same issue in Issue #32 , I just updated the MangaOCR version and its dependencies. I also changed a couple package references because it wasn't working for me when I tried to build the project or even run it in my IDE.
As for how it broke, someone who had Cloe for a while told me theirs was working fine but mine broke after resetting my PC. I had someone people install for the first time, they said the model wouldn't load. I think this mainly impacts users who download Cloe and load the model for the first time on their system somehow? But I'm not sure, this fixes it for me and others I had test it.
The error I received with the current build:
I have a build available on my fork, I'll remove it if you want/if you merge this change.