Handle blocked devices better (plus cleanups) #2821
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No functional changes * give variables better names * don't shadow variable from outerscope (dialog) * only set labels and iconnames variables in if/else blocks
* use_underline sets mnemonic on the label * ImageMenuItem without can be created without image data
I naively thought just adding it as menu option was enough. But, things like connecting obviously can't work. Also handle missing interface which BlueZ removes when a device is blocked.
infirit
force-pushed
the
blockedfixes
branch
from
34a5309 to
9d5a0c4
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also contains the cleanups from #2820
I decided on having a default
availablebut to keep it abstract to force each subclass to think about how to handle it.