Skip to content

Updated import module for NodeNG class of astroid package across all files#38

Open
Vaalarivan2002 wants to merge 9 commits intobluesheeptoken:masterfrom
Vaalarivan2002:master
Open

Updated import module for NodeNG class of astroid package across all files#38
Vaalarivan2002 wants to merge 9 commits intobluesheeptoken:masterfrom
Vaalarivan2002:master

Conversation

@Vaalarivan2002
Copy link

No description provided.

@kimci86 kimci86 linked an issue Dec 10, 2023 that may be closed by this pull request
@bluesheeptoken
Copy link
Owner

Hello @Vaalarivan2002 ,
Thank you very much for your contribution,
I will check the PR tomorrow :)

@Vaalarivan2002
Copy link
Author

Hey, @bluesheeptoken! Even after making these changes in the PR, since there are a lot of deprecations and removals of many classes from astroid, and there are a lot of dependencies on them inside your package, it requires a lot of changes here and there. Can you yourself make these changes if you have time since you know the system better? I really want to use your package to boil down another package's ~5000 lines of code to 64 KiB!

@bluesheeptoken
Copy link
Owner

Sure thing,
I didn't know pygolf was used for these use cases.
I will have a deeper look tomorrow :)

@bluesheeptoken
Copy link
Owner

Hey @Vaalarivan2002 , long time no see.
Is this something still needed ? (You probably found another solution in the meantime. Just checking if thus worth investigating time)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

No module named 'astroid.node_classes'

2 participants