WIP: make the timestamps part of the payload optional#173
Draft
tacaswell wants to merge 1 commit intobluesky:mainfrom
Draft
WIP: make the timestamps part of the payload optional#173tacaswell wants to merge 1 commit intobluesky:mainfrom
tacaswell wants to merge 1 commit intobluesky:mainfrom
Conversation
Contributor
|
Have you considered adding a field to schemas (and their documents) for "schema_version" so that people from the future can easily track which schema a particular instance was written against? This is a nice recommendation from the mongo folks (https://www.mongodb.com/blog/post/building-with-patterns-the-schema-versioning-pattern). It seems to me that this same logic would apply to non-mongo serializations as well. Granted, this particular schema change is easy to imply..."oh, there's not a datastamp? must have been after that was optional." Making it explicit might still be nice. |
Member
|
Related to #3 Thanks for the Mongo reference, @dylanmcreynolds. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Makes 'timestamps' option in the event schema, event page schema, and compose_* APIs.
Motivation and Context
As discussed on today pilot call, the
'timestamps'entry makes a lot of sense when the ultimate source of the data is a control systems (and fundamentally asynchronous) but makes much less sense for the output of data analysis.This is the minimal change to event model to allow this. There will need to be a companion change to databroker to cope with data that may not have timestamps.