Skip to content

reserve time and seq_num keys#223

Open
gwbischof wants to merge 3 commits intobluesky:mainfrom
gwbischof:reserved_keys
Open

reserve time and seq_num keys#223
gwbischof wants to merge 3 commits intobluesky:mainfrom
gwbischof:reserved_keys

Conversation

@gwbischof
Copy link
Contributor

@gwbischof gwbischof commented May 24, 2022

user-defined data_keys called "time" or "seq_num" conflict with with bluesky generated keys of the same name. This PR reserves this keys, preventing users from using them.

@gwbischof
Copy link
Contributor Author

@danielballan danielballan requested a review from tacaswell May 24, 2022 21:55
@tacaswell
Copy link
Contributor

Do we have any users currently using them?

@dmgav
Copy link
Contributor

dmgav commented May 25, 2022

@danielballan
Copy link
Member

The intent is to pair this with a migration tool (similar to "shape fixer") to alter the names on existing data.

@danielballan
Copy link
Member

This needs:

  • a substantial rebase, as the system for encoding schemas has evolved substantially
  • a clear story for how to deal with existing usage

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

Comments