Open
Conversation
danielballan
reviewed
Jul 8, 2019
Member
danielballan
left a comment
danielballan
left a comment
There was a problem hiding this comment.
Let's discuss the big picture in #98 first.
Contributor
Author
|
Fixes #98 |
|
|
||
| def validate_order(run_iterable): | ||
| """ | ||
| Validates the order of a Bluesky Run. |
Member
There was a problem hiding this comment.
Can you copy over the content from #98 here to explain what constraints this is enforcing?
| if name == 'event': | ||
| event_check(doc) | ||
| if name == 'event_page': | ||
| for event in unpack_event_page(doc): |
Member
There was a problem hiding this comment.
This does not address:
Event[Page]s across streams are in time order up to the time resolution of a Page. That is, if we denote event_page['time'][0] as a_i ("a initial") and event_page['time'][-1] as a_f ("a final") for a given EventPage a, if b follows a and then b_f >= a_i. In English, each EventPage's highest time must be greater than or equal to the preceding EventPages' lowest times.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Method to check that documents are generated in an acceptable order.