Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The maps link for iOS still isn't working properly, it's opening in the browser at maps.apple.com instead of launching the Apple Maps app.
Root cause:
Browser.open()is Capacitor's in-app browser and can't dispatch native URL schemes likemaps://to the OS. We need to usewindow.open()instead, which Capacitor routes to the OS handler on native platforms.The fix: Use
window.open()with native URL schemes (maps://for iOS,geo:for Android) to hand off directly to the OS, which opens the native Maps app. On web, we still useBrowser.open()with the Google Maps HTTPS link.Tested: Verified on Xcode iOS Simulator, Android Studio Android Emulator, and web build, all platforms now open maps correctly.