Fix custom URL HTML encoding in announcements (#249)#250
Merged
Conversation
Custom URLs with query parameters (containing &) were being HTML-encoded as & when passed through the REST API, breaking links. Changes: - Use esc_url_raw() instead of esc_url() in resolve_event_ref() - Add regression test for URL query parameter preservation - Add encoding guidelines to CLAUDE.md to prevent future issues - Add lint:esc-url script to check for esc_url() in REST contexts - Bump version to 1.8.6 Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
&) incorrectly HTML-encoded as&, causing links with query parameters to failcomposer lint:esc-urlscript to catchesc_url()usage in REST contextsRoot Cause
The
resolve_event_ref()method inAnnouncement.phpusedesc_url()which encodes&to&for HTML contexts. When this passes through the REST API to JSON, it becomes&.Fix: Changed to
esc_url_raw()which preserves&characters while still providing the same security (protocol validation, dangerous character removal).Test plan
https://httpbin.org/get?foo=1&bar=2)¬&Fixes #249
🤖 Generated with Claude Code