Skip to content

Comments

introducing Transaction Inspection Zone to block builder#459

Open
TenArmor wants to merge 2 commits intobnb-chain:masterfrom
TenArmor:tiz
Open

introducing Transaction Inspection Zone to block builder#459
TenArmor wants to merge 2 commits intobnb-chain:masterfrom
TenArmor:tiz

Conversation

@TenArmor
Copy link

No description provided.

- Proactive Vulnerability Response: in the event of an attack occuring it is crucial to act as quickly as possible, to do so protocols can registers actions for different situation beforehand, such as pausing protocol, disabling transfering of funds, etc.
- Builtin standard actions: rejecting transaction for the next block, notifying relavant parties, etc.

Once inspected, the cleared transactions are forwarded back to the block builder.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any design on validator side, like:

  1. what if a validator does not integrate MEV?
  2. or a validator do integrate with MEV but adopt local block eventually?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Validators can integrate with this system independently.

Current design does not necessarily involve any changes to the consensus or Geth codebase. We believe such a design brings ease of adoption at the builder level and maintains the overall stability of the blockchain.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this need all validator to integrate with the "TIZ", if one validator refuse to do so, the malicious tx will be included.

It it difficult to get every validator cooperate as this is not part of consensus rule.

@gandonghb
Copy link

gandonghb commented Dec 16, 2024

This proposal may have the following risks:

1.Over-reliance on predefined rules: the proposal emphasizes pre-registered actions, but the complexity and diversity of attacks may exceed the scope of these predefined rules. For example, some attacks may exploit unforeseen vulnerabilities in the protocol, causing the standard actions to fail. Additionally, malicious transactions might evade detection through obfuscation. As a result, we cannot fully ensure the absence of false negatives or false positives.

2.Negative impact on user experience and protocol credibility: If these protective mechanisms are triggered in non-attack scenarios (e.g., mistakenly pausing the protocol or rejecting transactions), it may result in user funds being frozen or transactions failing, which could harm the protocol’s reputation.

3.Performance impact on on-chain operations: built-in standard actions, such as "rejecting transactions for the next block," need to closely integrate with block generation logic. This may lead to performance overhead or delays in transaction confirmation on-chain.

In summary, the current design in the proposal may introduce instability to the blockchain. To advance this proposal, we may need a more detailed description of the mechanism, such as:

1.Enhancing dynamic response capabilities based on real-time status. For instance, after detecting an attack, the response strategy adjusts dynamically depending on the type of attack rather than relying solely on predefined actions.

2.Consider the impact of false positives.

3.Considering the efficiency of on-chain operations and the overall stability of the protocol.

4.Consider the technical complexity of the detection engine.

Copy link

@octavio12345300 octavio12345300 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

listo

Copy link

@octavio12345300 octavio12345300 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

List

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants