Skip to content

Conversation

@Razican
Copy link
Member

@Razican Razican commented Mar 5, 2021

cargo tarpaulin is failing on every commit due to xd009642/tarpaulin#517, which is also reported in cargo in rust-lang/cargo#9220, and should be fixed when rust-lang/cargo#9229 lands.

For the time being, we can deactivate coverage checks, which should make builds start to pass again.

@Razican Razican added bug Something isn't working test Issues and PRs related to the tests. labels Mar 5, 2021
@Razican Razican added this to the v0.12.0 milestone Mar 5, 2021
@Razican Razican changed the title Fixing cargo tarpaulin Deactivating cargo tarpaulin Mar 5, 2021
@github-actions
Copy link

github-actions bot commented Mar 5, 2021

Test262 conformance changes:

Test result master count PR count difference
Total 78,497 78,497 0
Passed 24,986 24,986 0
Ignored 15,587 15,587 0
Failed 37,924 37,924 0
Panics 16 16 0
Conformance 31.83 31.83 0.00%

@github-actions
Copy link

github-actions bot commented Mar 5, 2021

Benchmark for 9677183

Click to view benchmark
Test PR Benchmark Master Benchmark %
Arithmetic operations (Execution) 380.3±0.18ns 377.7±0.29ns +0.69%
Arithmetic operations (Full) 242.5±0.41µs 241.0±0.24µs +0.62%
Array access (Execution) 6.5±0.04µs 6.5±0.03µs 0.00%
Array access (Full) 266.3±0.44µs 268.1±0.93µs -0.67%
Array creation (Execution) 3.2±0.00ms 3.2±0.00ms 0.00%
Array creation (Full) 3.3±0.00ms 3.2±0.00ms +3.13%
Array pop (Execution) 1008.5±3.90µs 1007.0±4.32µs +0.15%
Array pop (Full) 1446.6±17.13µs 1449.2±1.30µs -0.18%
Boolean Object Access (Execution) 5.4±0.01µs 5.4±0.03µs 0.00%
Boolean Object Access (Full) 266.6±1.50µs 261.6±0.39µs +1.91%
Clean js (Execution) 715.8±5.42µs 719.7±4.01µs -0.54%
Clean js (Full) 1021.3±9.46µs 1017.8±10.59µs +0.34%
Clean js (Parser) 45.9±0.04µs 46.1±2.18µs -0.43%
Create Realm 477.2±0.29ns 494.2±0.43ns -3.44%
Dynamic Object Property Access (Execution) 5.3±0.02µs 5.3±0.02µs 0.00%
Dynamic Object Property Access (Full) 263.2±0.32µs 261.8±0.59µs +0.53%
Expression (Parser) 7.5±0.01µs 7.5±0.01µs 0.00%
Fibonacci (Execution) 898.8±0.68µs 901.5±2.22µs -0.30%
Fibonacci (Full) 1178.7±1.31µs 1176.4±2.65µs +0.20%
For loop (Execution) 24.3±0.17µs 24.2±0.14µs +0.41%
For loop (Full) 284.9±0.37µs 285.4±0.40µs -0.18%
For loop (Parser) 22.1±0.04µs 21.9±0.03µs +0.91%
Goal Symbols (Parser) 15.4±0.04µs 15.3±0.18µs +0.65%
Hello World (Parser) 4.2±0.01µs 4.2±0.02µs 0.00%
Long file (Parser) 825.1±1.35ns 822.0±0.72ns +0.38%
Mini js (Execution) 640.1±4.34µs 641.0±3.54µs -0.14%
Mini js (Full) 923.9±3.44µs 922.4±5.55µs +0.16%
Mini js (Parser) 40.4±0.03µs 40.3±0.05µs +0.25%
Number Object Access (Execution) 4.3±0.01µs 4.3±0.00µs 0.00%
Number Object Access (Full) 257.9±6.27µs 255.8±0.34µs +0.82%
Object Creation (Execution) 4.5±0.01µs 4.5±0.01µs 0.00%
Object Creation (Full) 259.7±0.40µs 261.0±0.90µs -0.50%
RegExp (Execution) 11.6±0.03µs 11.4±0.04µs +1.75%
RegExp (Full) 272.0±0.49µs 275.5±0.69µs -1.27%
RegExp Literal (Execution) 11.6±0.05µs 11.5±0.02µs +0.87%
RegExp Literal (Full) 270.3±0.78µs 267.8±0.49µs +0.93%
RegExp Literal Creation (Execution) 10.1±0.12µs 10.1±0.04µs 0.00%
RegExp Literal Creation (Full) 261.9±0.35µs 262.6±0.76µs -0.27%
Static Object Property Access (Execution) 4.8±0.01µs 4.8±0.01µs 0.00%
Static Object Property Access (Full) 260.4±0.30µs 259.0±0.35µs +0.54%
String Object Access (Execution) 7.5±0.01µs 7.5±0.01µs 0.00%
String Object Access (Full) 266.3±0.44µs 266.2±0.46µs +0.04%
String comparison (Execution) 6.9±0.04µs 6.9±0.04µs 0.00%
String comparison (Full) 263.3±0.82µs 260.9±0.48µs +0.92%
String concatenation (Execution) 5.5±0.02µs 5.6±0.02µs -1.79%
String concatenation (Full) 257.5±0.38µs 253.9±0.37µs +1.42%
String copy (Execution) 4.2±0.01µs 4.1±0.05µs +2.44%
String copy (Full) 249.5±0.31µs 246.8±0.52µs +1.09%
Symbols (Execution) 3.5±0.01µs 3.5±0.01µs 0.00%
Symbols (Full) 243.9±0.36µs 244.5±0.51µs -0.25%

@Lan2u Lan2u merged commit 25ae30a into master Mar 6, 2021
Razican added a commit that referenced this pull request May 22, 2021
* Fixing cargo tarpaulin

* Disable coverage checks
@jasonwilliams jasonwilliams deleted the fix_tarpaulin branch October 5, 2021 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working test Issues and PRs related to the tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants