Fix case when undecodable characters are encountered on Windows #27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StanFromIreland
changed the title
StanFromIreland
commented
Nov 2, 2025
| else: | ||
| raise ValueError("unsupported error handling") | ||
| return outres.decode() + out1, inlen + len1 + 1 | ||
| raise |
Contributor
Author
There was a problem hiding this comment.
Consistent with encode implementation, I assume this was an oversight.
Owner
There was a problem hiding this comment.
Yes, we should definitely always return a tuple or raise an error.
Owner
|
Just silently returning a partially converted result seems dangerous. Can we use the same error handling as with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.