Skip to content

Fix evaluation order of assignments to fields. #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mattmccutchen-microsoft wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix evaluation order of assignments to fields. #4

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions BytecodeTranslator/ExpressionTraverser.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1076,16 +1076,19 @@ private void TranslateAssignment(Bpl.IToken tok, object container, IExpression/*

var/*?*/ field = container as IFieldReference;
if (field != null) {
this.Traverse(source);
var e = this.TranslatedExpressions.Pop();
var f = Bpl.Expr.Ident(this.sink.FindOrCreateFieldVariable(field));
if (instance == null) {
this.Traverse(source);
var e = this.TranslatedExpressions.Pop();
// static fields are not kept in the heap
StmtTraverser.StmtBuilder.Add(Bpl.Cmd.SimpleAssign(tok, f, e));
}
else {
this.Traverse(instance);
var x = this.TranslatedExpressions.Pop();
// The source must be evaluated after the instance.
this.Traverse(source);
var e = this.TranslatedExpressions.Pop();
var boogieType = sink.CciTypeToBoogie(field.Type);
this.sink.Heap.WriteHeap(tok, x, f, e,
field.ResolvedField.ContainingType.ResolvedType.IsStruct ? AccessType.Struct : AccessType.Heap,
Expand Down