Remove the phone code, as agreed with Mike and Shaz.#5
Open
mattmccutchen-microsoft wants to merge 1 commit intoboogie-org:masterfrom
Open
Remove the phone code, as agreed with Mike and Shaz.#5mattmccutchen-microsoft wants to merge 1 commit intoboogie-org:masterfrom
mattmccutchen-microsoft wants to merge 1 commit intoboogie-org:masterfrom
Conversation
Collaborator
Author
|
@shazqadeer, can you please sanity check this before I merge it (or suggest someone else to do so)? |
The immediate motivation is that I want to move to the new version of CCI (https://github.com/Microsoft/cci), which does not include the ILGarbageCollect project, which is used by the phone plugin. I removed everything phone-related (there were no unclear cases) and all local variables left unused, but not any of the larger-scale extensibility points that are no longer used.
mattmccutchen-microsoft
force-pushed
the
remove-phone
branch
from
b4a0bc9 to
a04c29b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The immediate motivation is that I want to move to the new version of CCI
(https://github.com/Microsoft/cci), which does not include the
ILGarbageCollect project, which is used by the phone plugin.
I removed everything phone-related (there were no unclear cases) and all
local variables left unused, but not any of the larger-scale extensibility
points that are no longer used.