Add option to compute conf. interval from std err#3
Open
ilirmaci wants to merge 1 commit intobookingcom:mainfrom
Open
Add option to compute conf. interval from std err#3ilirmaci wants to merge 1 commit intobookingcom:mainfrom
ilirmaci wants to merge 1 commit intobookingcom:mainfrom
Conversation
Add `use_std_error` argument to all procedures that compute a confidence interval through bootstrapping. Default to True because this method is more efficient and more familiar. Add explanation and retouch literature reference in docstring
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
use_std_errorargument to all procedures that compute aconfidence interval through bootstrapping. Default to True
because this method is more efficient and more familiar.
Add explanation and retouch literature reference in docstring
Solution to #1
Missing: tests do not cover both computation methods as they are
written now. Writing tests for every metric would take a lot of duplication.