Feat: Add support to install FILE_SET too #102
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ClausKlein
force-pushed
the
feature/install-file_set
branch
from
bd832ca to
4dc5912
Compare
nigels-com
reviewed
Dec 14, 2025
include/BoostInstall.cmake
Outdated
| string(APPEND CONFIG_INSTALL_DIR "-static") | ||
| endif() | ||
|
|
||
| if(NOT CMAKE_VERSION VERSION_LESS 3.28) |
There was a problem hiding this comment.
Would suggest VERSION_GREATER_EQUAL rather than inverted logic.
nigels-com
reviewed
Dec 14, 2025
include/BoostInstall.cmake
Outdated
|
|
||
| install(EXPORT ${LIB}-targets DESTINATION "${CONFIG_INSTALL_DIR}" NAMESPACE Boost:: FILE ${LIB}-targets.cmake) | ||
| install(EXPORT ${LIB}-targets DESTINATION "${CONFIG_INSTALL_DIR}" NAMESPACE Boost:: FILE ${LIB}-targets.cmake | ||
| # XXX CXX_MODULES_DIRECTORY . |
pdimov
reviewed
Dec 16, 2025
| if(INTERFACE_CXX_MODULE_SETS) | ||
| boost_message(DEBUG "boost_install_target: '${__TARGET}' has INTERFACE_CXX_MODULE_SETS=${INTERFACE_CXX_MODULE_SETS}") | ||
| set(__INSTALL_CXX_MODULES FILE_SET ${INTERFACE_CXX_MODULE_SETS} DESTINATION ${CONFIG_INSTALL_DIR}) | ||
| set(__INSTALL_CXX_MODULES_BMI CXX_MODULES_BMI DESTINATION ${CONFIG_INSTALL_DIR}/bmi-${CMAKE_CXX_COMPILER_ID}_$<CONFIG>) |
Member
There was a problem hiding this comment.
I'm not sure we need to be installing these. From what I read, it's not a recommended practice to do so.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
with boost/any and boost/type_info there are at leaset 2 libs preparing CXX_MODULES
This patch would enable to install it too