Feature/hash_is_avalanching #40
Conversation
test/hash_is_avalanching_test.cpp
Outdated
| BOOST_TEST_TRAIT_FALSE(( hash_is_avalanching< boost::hash<std::basic_string<my_char> > > )); | ||
| #endif | ||
|
|
||
| BOOST_TEST_TRAIT_FALSE(( hash_is_avalanching< std::hash<std::string > > )); |
There was a problem hiding this comment.
It's an example of a struct without a nested is_avalanching.
There was a problem hiding this comment.
Please use a struct without a nested is_avalanching, then.
I don't want to guarantee that hash_is_avalanching is false for std::hash<std::string>.
test/hash_is_avalanching_test.cpp
Outdated
| BOOST_TEST_TRAIT_FALSE(( hash_is_avalanching< std::hash<std::string > > )); | ||
| BOOST_TEST_TRAIT_TRUE(( hash_is_avalanching< X > )); | ||
| BOOST_TEST_TRAIT_TRUE(( hash_is_avalanching< Y > )); | ||
| BOOST_TEST_TRAIT_FALSE(( hash_is_avalanching< Z > )); |
There was a problem hiding this comment.
Let's put these three in their own test (plus one without is_avalanching) and leave this one alone.
|
Looks almost good to go. You just need to remove one include to make the cmake tests pass. |
|
I wonder whether
|
2 participants
This is part 1 of the process of migrating
hash_is_avalanchingfrom Boost.Unordered to Boost.ContainerHash; part 2 will redefineboost::unordered::hash_is_avalanchingas a using declaration ofboost::container_hash::hash_is_avalanchingand deprecate<boost/unordered/hash_traits.hpp>.