Skip to content

Conversation

@awulkiew
Copy link
Member

  1. Boost.Range version of boost::move() and boost::move_backward() using Boost.Move implementations of these algorithms - boost::move() and boost::move_backward().
  2. moved_range wraps Boost.Move boost::move_iterator<>.
  3. added adaptors::move() and moved forwarder.
  4. Fixed error in copy_backward() test - wrong parameters were passed and wrong result was expected.

@neilgroves
Copy link
Collaborator

This looks like some cool functionality. Since there is renewed effort to modularise Boost I am proposing that the tokenized adaptor is moved to Boost.RegEx. I think that this adaptor should probably live in Boost.Move and therefore I am not going to merge this right now until the modularisation strategy is clear.

It may be the case that we continue to put adaptors into Boost.Range at the cost of having numerous dependencies. If this turns out to be the case then I shall merge this straight in, otherwise I hope to use the code as a base for implementation that will go into Boost.Move (if the Boost.Move maintainer agrees).

@awulkiew
Copy link
Member Author

For now, at least copy_backward() test fix could be cherry-picked.
awulkiew@8849b85

@neilgroves
Copy link
Collaborator

I am grateful that you highlighted the problems with the copy_backward unit test. Upon inspection I realised that I had not completed the unit test and that the coverage was insufficient. I have therefore improved coverage and fixed the mistakes rather than merge this change. This is pushed to the develop branch and after the tests cycle will appear on master ready for 1.56.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants