Add column title (padding, icon-size, and checkBox size to auto-fit calculation #715
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o autoFitColumn calculation
Contributor
Author
|
@bosskmk Can you please take a look at this? |
Owner
|
@Milad-Akarie |
Owner
|
I checked the code. |
Contributor
Author
|
@bosskmk I don't think this PR is merged? |
Contributor
Author
|
@bosskmk any updates here? |
Contributor
Author
|
Hey @bosskmk grouped rows are now considered in the calculation
|
add more space for calculated title width
Contributor
Author
|
Hey @bosskmk is there a problem with this PR? |
doonfrs
added a commit
to doonfrs/pluto_grid_plus
that referenced
this pull request
Dec 7, 2023
bastaware
pushed a commit
to bastaware/pluto_grid
that referenced
this pull request
Feb 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello @bosskmk
as the title suggests the current column auto-fit function does not consider column title, padding, icon-size ..etc and this PR should fix that
This's the before behaviour
And this's the after behaviour
NOTE
The columnAutoFit test fails now and honestly I have no idea how to test the new implementation as the old test was comparing the auto-fitted width to a fixed width ( min column width ).