feat(notifications): implement /me/notifications with global unread sync#400
Open
jaydendancer12 wants to merge 1 commit intoboundlessfi:mainfrom
Open
feat(notifications): implement /me/notifications with global unread sync#400jaydendancer12 wants to merge 1 commit intoboundlessfi:mainfrom
jaydendancer12 wants to merge 1 commit intoboundlessfi:mainfrom
Conversation
|
@jaydendancer12 is attempting to deploy a commit to the Threadflow Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implemented the new notifications experience for
/me/notificationsand wired it so unread state stays globally in sync across navigation surfaces.What’s included
/me/notifications/notificationsfor compatibility and redirected it to/me/notificationsunreadCount(removed hardcoded value)NewEarlierArchivedBoundlessSheetwith full content + metadataMark all as readat top of feed when unread items exist--
Technical changes
Added:
app/me/notifications/page.tsxcomponents/providers/notification-provider.tsxUpdated:
app/(landing)/notifications/page.tsxapp/providers.tsxcomponents/app-sidebar.tsxcomponents/nav-main.tsxcomponents/notifications/NotificationBell.tsxcomponents/notifications/NotificationDropdown.tsxcomponents/notifications/NotificationItem.tsxcomponents/notifications/NotificationList.tsxhooks/use-notification-polling.tshooks/useNotifications.ts--
Validation
Automated:
npm run lint✅npm run build✅Manual:
New,Earlier,Archived✅BoundlessSheetwith full details ✅Mark all as readupdates UI + count and animates out ✅--
Evidence
Closes #396
@0xdevcollins would you mind looking this over for me whenever you get the chance? Hope I could be a helping hand for your project!