Stricter type checking for coordinates #4
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Stefan Fochler <s.fochler@box-id.com>
iStefo
reviewed
Jun 23, 2025
lib/value_formatters.ex
Outdated
Comment on lines
91
to
92
| [lat, _lng, _radius] when is_number(lat) or is_binary(lat) -> "coordinates" | ||
| [lat, _lng] when is_number(lat) or is_binary(lat) -> "coordinates" |
There was a problem hiding this comment.
I think we should extend the check to all entries of the list (even though it won't make for the prettiest code), what do you think?
Member
Author
There was a problem hiding this comment.
Seems like a bit of an overkill for now, but might be useful int he future I guess. I'll extend it
iStefo
approved these changes
Jun 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.