Update matrix and vector initialization #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
31 tasks
bpfaff
approved these changes
Jan 15, 2023
Owner
bpfaff
left a comment
bpfaff
left a comment
There was a problem hiding this comment.
Hi Dirk, a happy new year and many thanks for the patch. Best wishes, Bernhard
Contributor
Author
|
Thanks, and Happy New Year to you too! Thanks for the quick approval, merge and upload by April would be great. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Very sorry about apparently having forgotten one change set in pull request #3 I sent a few months ago, and which you kindly merged, and updated at CRAN. Because of my oversight, we will need another round. It would be much appreciated if you could do another (trivial, my bad for the extra work) round at CRAN.
(We could upate the initialization of
Gjust above similarly. C++11 brace initialization work withx = { 1, 2, 3 };where vector dimensions are automatic, for matrices it works row-wise as I explicitly tested soM = { {1, 2}, {3, 4} };becomes a matrix with rows{1, 2}and{3, 4}.