Jasmine suite fixes, a start on Dateinput specs#1
Open
ches wants to merge 6 commits intobradrobertson:testingfrom
Open
Jasmine suite fixes, a start on Dateinput specs#1ches wants to merge 6 commits intobradrobertson:testingfrom
ches wants to merge 6 commits intobradrobertson:testingfrom
Conversation
- correct library paths - don't load SpecHelper twice - local jQuery 1.6.2 -- not being able to run tests offline isn't cool
Not complete coverage, but hopefully can serve as an initial example.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey Brad,
This fixes some suite load paths, uses git submodules for jasmine and jasmine-jquery so they can be updated easily without uninteresting diffs in the core project, and incorporates the initial Dateinput specs you added and then removed plus some expansion on those.
There is a failing and pending spec related to jquerytools#480.
Let me know your thoughts!