Skip to content

Conversation

@mohamedhafez
Copy link

@mohamedhafez mohamedhafez commented Oct 29, 2025

Summary

Fixes #250

Checklist

  • Added changelog entry (If there isn't an #unreleased section, add that and your changelog entry to the top of the changelog)

  • Ran unit tests (rake test:unit):
    Note: to get the tests to run on Ruby 3.2 and 3.3, i had to temporarily remove the require "pry" line from spec/spec_helper.rb. That change is not part of this PR because its part of the larger issue of getting the tests working on modern, maintained Ruby versions. I also don't know if pry is still required for integration tests, so i didn't want to remove it. All unit tests passed on Ruby 3.2 and 3.3. Testing on Ruby 3.4 succeeded except for two trivial failures related to expecting the old representation of hashes (i.e. {:a => "b"} as opposed to {a: "b"}

  • I alphabetized all attributes, parameters, and methods by name in any class file I changed

  • I have linked the JIRA ticket in the summary section
    not applicable

  • I have reviewed the JIRA ticket to ensure all AC's are met
    not applicable

  • I understand that unless this is a Draft PR or has a DO NOT MERGE label, this PR is considered to be in a deploy ready state and can be deployed if merged to main

@zorab47
Copy link

zorab47 commented Dec 11, 2025

Thanks, the gem does need these changes to stay up-to-date with recent Ruby versions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Braintree library errors on Ruby 3.4 due to missing dependencies

2 participants