-
Notifications
You must be signed in to change notification settings - Fork 45
Add IOverride cache #89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks for the PR and making the changes! Hopefully I'll have a chance to follow-up / validate next weekend. |
|
Alright, applied all requested changes and fixes (including missed typo) |
|
Gentle bump :) |
|
I haven't forgotten about you. I only really get to work on OSS on weekends, and not every weekend. Thanks for your patience. |
|
Hi @brandonbloom, following up, it's been a while - are there any other changes you'd like me to make in the PR? |
|
Hey, following up again on the PR's first birthday, typo has been fixed long time ago and awaiting your review. |
|
These changes seem to break the ClojureScript tests. Please run Example failure: |
Turns out that was needed
Why get greedy
|
@brandonbloom got around to fixing it, turns out I just needed to increase node's stack size. |
|
This PR has been included in release v0.6.28! 🎉 |
This reverts commit 2ea338e.
|
This had to be reverted and fixed a different way. See #94 |
Speeds up
:longbenchmark ~2.5x and:mixed~2xCloses #87