FIX #85: Special handling for java.sql.Date #93
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
java.sql.Date is a subclass of java.util.Date but throws a runtime exception `UnsupportedOperationException` when called, because a SQL date inherently has no time information associated with it. It is just a date. Therefore a special case is added to the protocol to support pretty printing java.sql.Date objects.
Contributor
Author
|
This'd fix #85 |
Owner
|
Could you add some tests to ednize_test.cljc please? |
Contributor
Author
Sure can! Do you have a target level for the test coverage? I added a similar level that was currently there for this PR. |
Owner
Time zone issue? |
We can just use toString to get the correct format. The older version of the test depended upon being in the correct timezone.
Contributor
Author
Indeed. As far as I can tell the problem was in constructing the test data more than the actual implementation. I simplified the printing implementation though, as I noticed that toString does the right thing. |
Owner
|
Thanks! changes are now on master branch, |
Owner
|
This PR has been included in release v0.6.28! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
java.sql.Date is a subclass of java.util.Date but throws a runtime exception
UnsupportedOperationExceptionwhen called, because a SQL date inherently has no time information associated with it. It is just a date.Therefore a special case is added to the protocol to support pretty printing java.sql.Date objects.