Generate value-*-stub.h correctly#7
Open
12qu wants to merge 1 commit intobrazdil:masterfrom
12qu:master
Open
Conversation
These files should be automatically generated by `dbus-binding-tool` when `make` is run, since not doing so can cause bugs when the dbus interface changes and these files do not. Such a bug actually occurred when the recent "volume while muted" patch was merged, which prompted the need for this commit. The old dbus interface was still in use, even though a new boolean parameter had been added to it, and so the whole program failed to compile out of the box.
This was referenced Oct 11, 2015
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These files should be automatically generated by
dbus-binding-toolwhen
makeis run, since not doing so can cause bugs when the dbusinterface changes and these files do not.
Such a bug actually occurred when the recent "volume while muted" patch
was merged, which prompted the need for this commit. The old dbus
interface was still in use, even though a new boolean parameter had been
added to it, and so the whole program failed to compile out of the box.