Added a bunch of new endpoints, all of them linked to club activities#31
Open
Sigeth wants to merge 12 commits intobreeku:masterfrom
Open
Added a bunch of new endpoints, all of them linked to club activities#31Sigeth wants to merge 12 commits intobreeku:masterfrom
Sigeth wants to merge 12 commits intobreeku:masterfrom
Conversation
Author
|
Is there anything that I need to change ? |
Owner
Hey, sorry it's taking time to answer... By quick glance it look's good! I will have to test the functions myself before we merge. I will try to get it done this week |
Author
|
If you want, I can change the .spec.ts file so you can gain some time, and just test it more easily, I just have to figure out how the format works |
I realised that "buckets" are used to store items, so it can leads to a skin-upload, but also a map-upload or an item-upload
Author
|
So I've done the tests, you can use it if it's good :D |
Author
|
🆙 |
Author
|
🆙 🆙 🆙 😄 |
voblivion
reviewed
Aug 31, 2021
| } | ||
|
|
||
| /** | ||
| * This is used to obtain the competitions in the Events section of the game |
There was a problem hiding this comment.
Copy-paste mistake "competitions" -> "activities"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
New endpoints supported for the live services part
What is the current behavior? (You can also link to an open issue here)
/
What is the new behavior (if this is a feature change)?
Added :
getClubCampaignById
getClubRoomById
getClubSkins
getClubBucketById
getClubById
getClubActivitiesById
Tests for all of these functions
Other information:
Now it's better than the last time xD
Hope it's all good !