An attempt to fix syntax highlighting#154
Open
paulstelian97 wants to merge 1 commit intobrianleroux:masterfrom
Open
An attempt to fix syntax highlighting#154paulstelian97 wants to merge 1 commit intobrianleroux:masterfrom
paulstelian97 wants to merge 1 commit intobrianleroux:masterfrom
Conversation
Contributor
|
Well, I doubt, this will ever be approved. As any other PR over here won't. But if you're still interested in doing this PR, feel free to re-submit it in my self-hosted fork https://github.com/shaedrich/wtfjs |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please separate this commit into two commits:
marked.js. This added a dependency onhighlight.js. Reference.-> Attempted to add support for highlight.js in /src/html/get-wtfs-000wtfID. Please add a dependency for
highlight.jsand correct therequirestatement on line 51-> Attempted fix Javascript highlighting as on my own suggestion in issue #153
-> Renamed 2013-12-15-... according to issue #152
-> 2016-03-10-... had the correct language already
-> Added comment to 2010-06-02-instances-and-default-values; also might have broken code blocks
-> Added comment to 2010-11-15-i-am-myself-but-also-not-myself
-> Might have broken code blocks in 2011-07-26-iteration-denormalization
-> Vim gave up on syntax highlighting so please check code blocks in 2011-11-11-...
-> Vim is also confused on 2012-08-11-Slashes!
-> 2012-10-10-infinity-madness had "js" as language; not sure if that is recognized though; I changed to "javascript"
-> Several others have Vim getting confused; I will not list them all; if it's broken on any of the pages above reject my PR and tell me
-> Skipped 2013-10-02* (HTML+Javascript, IDK what the correct language is)
-> 2013-12-19 Syntax highlighting may make that one more obvious