Skip to content

Comments

Add shared types module#22

Merged
phertyameen merged 4 commits intobridgelet-org:mainfrom
Mackenzie-OO7:shared-types-module
Jan 26, 2026
Merged

Add shared types module#22
phertyameen merged 4 commits intobridgelet-org:mainfrom
Mackenzie-OO7:shared-types-module

Conversation

@Mackenzie-OO7
Copy link
Contributor

Closes #12

Note

  • Compilation kept failing because soroban_sdk::crypto::Client::sha256 strictly requires soroban_sdk::Bytes, but got passed soroban_sdk::Vec<u8>. These types are not interchangeable in the Soroban environment so i refactored authorixation.rs a bit

  • I created a root cargo workspace for all the contract directories to share so they can easily use relative paths

Copy link
Contributor

@phertyameen phertyameen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your cicd is failing:
run

cargo clippy 
cargo build

in the affected contract directory to resolve contract test errors

Copy link
Contributor

@phertyameen phertyameen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awsome work!

@phertyameen phertyameen merged commit bb34da1 into bridgelet-org:main Jan 26, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add Shared Types Module

2 participants