Fix/issue 46 address validation in validation provider tests#56
Merged
phertyameen merged 3 commits intobridgelet-org:mainfrom Feb 21, 2026
Conversation
phertyameen
requested changes
Feb 20, 2026
Contributor
phertyameen
left a comment
phertyameen
left a comment
There was a problem hiding this comment.
Nice work over all! Just remove that last comment and we are good to merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #46
All validation.provider.spec.ts features implemented
All test code is uncommented
All Stellar addresses are exactly 56 characters
All addresses pass StrKey.isValidEd25519PublicKey() validation
All 14 tests pass successfully