Chore: Refactor ExecuteSweepDto to Domain Command #58
Open
dimka90 wants to merge 1 commit intobridgelet-org:mainfrom
Open
Chore: Refactor ExecuteSweepDto to Domain Command #58dimka90 wants to merge 1 commit intobridgelet-org:mainfrom
dimka90 wants to merge 1 commit intobridgelet-org:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Description
Summary
Refactored the internal sweep execution model to accurately reflect its role as a Domain Command rather than a transport-layer DTO. This change ensures internal orchestration contracts are clearly distinguished from API payload models, aligning with NestJS architectural patterns.
Changes
ExecuteSweepDtointerface to SweepExecutionRequest.execute-sweep.dto.tsto execute-sweep.command.ts.sweepsmodule, replacing genericdtowith descriptivecommandorsweepCommand.Why this matters
Verification Results
All checks required by CONTRIBUTING.md have been performed and passed:
npm run lintpassed.npm run buildpassed.npm test -- sweeps.service.spec.tspassed.Non-Goals achieved
Closes #51