Adding new class and fixing IngestRequest class to allow retranscoding requests.#18
Open
Tiriel wants to merge 3 commits intobrightcove:masterfrom
Tiriel:master
Open
Adding new class and fixing IngestRequest class to allow retranscoding requests.#18Tiriel wants to merge 3 commits intobrightcove:masterfrom Tiriel:master
Tiriel wants to merge 3 commits intobrightcove:masterfrom
Tiriel:master
Conversation
tamasd
suggested changes
Jul 5, 2018
|
|
||
| use Brightcove\Object\ObjectBase; | ||
|
|
||
| class IngestRequestRetranscode extends ObjectBase { |
Contributor
There was a problem hiding this comment.
I'd prefer to have a common ancestor for IngestRequestMaster and IngestRequestRetranscode even if they have no common properties. This would signal that they are related.
| } | ||
|
|
||
| public static function createRequest($url, $profile) { | ||
| public static function createRequest($profile, $url = null) { |
Contributor
There was a problem hiding this comment.
I think the parameter order shouldn't be swapped, and the possiblity of a null url should be documented (we cannot drop PHP 5 now, but in PHP 7.1+ the type should be ?string).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a new class IngestRequestRetranscode with single attribute use_archived_master mirroring Brightcove Dynamic Ingest API field, to be filled with bool (default to true).
Modified IngestRequest::createIngest() to reflect new possibility: changed param order to make $url optional, create conditional statement for selecting proper IngestRequestMaster/Retranscode field.