Added analytics request method to Client class#21
Open
dividemysky wants to merge 1 commit intobrightcove:masterfrom
Open
Added analytics request method to Client class#21dividemysky wants to merge 1 commit intobrightcove:masterfrom
dividemysky wants to merge 1 commit intobrightcove:masterfrom
Conversation
tamasd
suggested changes
Jul 5, 2018
Contributor
tamasd
left a comment
tamasd
left a comment
There was a problem hiding this comment.
This functioanlity should have its own class, like CMS, DI or PM, and not be a part of the Client class.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a method to the Client class to allow requests to the Analytics API. An additional method is necessary because the URL formatting and options are different for the Analytics endpoint.