Skip to content

Conversation

@liam-o-marsh
Copy link
Contributor

also, a weird edge-case was patched for borderless circles

I might need to run this version on a couple of inkscape versions
the second commit contains a few refactors, but you can also choose not to include it if you want

@briling
Copy link
Owner

briling commented May 8, 2024

@liam-o-marsh does it work for you right now?

@liam-o-marsh
Copy link
Contributor Author

@briling inkscape 1.3.2 and it works. why?
(sorry it took me 2W to get to this)

@briling
Copy link
Owner

briling commented May 23, 2024

Weird... 2W ago I tried with Inkscape 1.3 (0e150ed, 2023-07-21) and got weird errors, now they're gone.
Is this fix supposed to be compatible with 1.0.x?

'''

l = abs(y1-y0)
assert 0.5*h <= r0 , f"bad h parameter, should be less or equal to {2*r0}"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"bad" parameter actually works -- gives a weird looking bond but I thought it might be not useless

@briling
Copy link
Owner

briling commented Jul 2, 2024

Finally found that for me even the old version breaks when the bubbles are of the same size, even though it's supposed to treat this case separately

@liam-o-marsh
Copy link
Contributor Author

that's weird, it works on my side... both with the exact same size and with an epsilon difference.
do you have a file and inkscape version that actually causes this bug?

@briling
Copy link
Owner

briling commented Jul 4, 2024

Haven't saved it then because I was in a hurry and now can't reproduce the bug! It happened with the second circle being a copy of the first one (probably in some specific circumstances)...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants