Skip to content

Implement Date.Prototype.{getHours,getMinutes,getSeconds}. #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
progval wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Implement Date.Prototype.{getHours,getMinutes,getSeconds}. #37

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
57 changes: 51 additions & 6 deletions envs/es5.env
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3604,10 +3604,13 @@ let [%IsFinite] = func(n) {
prim("!", (n !== n || n === +inf || n === -inf))
}

// http://es5.github.com/#x15.9.1.2
// http://es5.github.com/#x15.9.1.2 and http://www.ecma-international.org/ecma-262/5.1/#sec-15.9.1.10
let [%HoursPerDay] = 24
let [%MinutesPerHour] = 60
let [%SecondsPerMinute] = 60
let [%msPerDay] = 86400000
let [%msPerHour] = 3600000
let [%msPerMin] = 60000
let [%msPerMinute] = 60000
let [%msPerSecond] = 1000
let [%Day] = func(t) { prim("floor", prim("/", t, %msPerDay)) }
let [%TimeWithinDay] = func(t) { prim("%", t, %msPerDay) }
Expand Down Expand Up @@ -3741,6 +3744,21 @@ let [%DateFromTime] = func(t) {
else { %TypeError("Something terrible happened in %DateFromTime")}
}

// http://www.ecma-international.org/ecma-262/5.1/#sec-15.9.1.10
let [%HourFromTime] = func(t) {
prim("%", prim("floor", prim("/", t, %msPerHour)), %HoursPerDay)
}

// http://www.ecma-international.org/ecma-262/5.1/#sec-15.9.1.10
let [%MinFromTime] = func(t) {
prim("%", prim("floor", prim("/", t, %msPerMinute)), %MinutesPerHour)
}

// http://www.ecma-international.org/ecma-262/5.1/#sec-15.9.1.10
let [%SecFromTime] = func(t) {
prim("%", prim("floor", prim("/", t, %msPerSecond)), %SecondsPerMinute)
}

let [%LocalTime] = func(t) { t }

let [%MakeDate] = func(day, time) { prim("+", prim("*", day, %msPerDay), time) }
Expand Down Expand Up @@ -3792,7 +3810,7 @@ let [%MakeTime] = func(h, m, s, ms) {
prim("+",
prim("+",
prim("*", hour, %msPerHour),
prim("*", min, %msPerMin)),
prim("*", min, %msPerMinute)),
prim("*", sec, %msPerSecond)),
millis)) {
t
Expand Down Expand Up @@ -3933,6 +3951,33 @@ let [%dategetDate] = {[#code: %dategetDateLambda, #proto : %FunctionProto,]}

{%define15Property(%DateProto, "getDate", %dategetDate)}

let [%dategetHoursLambda] = func(this, args) {
let (t = this[<#primval>])
if (t === NaN) { t } else { %HourFromTime(%LocalTime(t)) }
}

let [%dategetHours] = {[#code: %dategetHoursLambda, #proto : %FunctionProto,]}

{%define15Property(%DateProto, "getHours", %dategetHours)}

let [%dategetMinutesLambda] = func(this, args) {
let (t = this[<#primval>])
if (t === NaN) { t } else { %MinFromTime(%LocalTime(t)) }
}

let [%dategetMinutes] = {[#code: %dategetMinutesLambda, #proto : %FunctionProto,]}

{%define15Property(%DateProto, "getMinutes", %dategetMinutes)}

let [%dategetSecondsLambda] = func(this, args) {
let (t = this[<#primval>])
if (t === NaN) { t } else { %SecFromTime(%LocalTime(t)) }
}

let [%dategetSeconds] = {[#code: %dategetSecondsLambda, #proto : %FunctionProto,]}

{%define15Property(%DateProto, "getSeconds", %dategetSeconds)}

let [%defineNYIProperty] = func(base, name) {
let (unimplFunc = func(this, args) {
%TypeError(prim("string+", name, " NYI"))
Expand All @@ -3951,11 +3996,11 @@ let [%defineNYIProperty] = func(base, name) {
// %defineNYIProperty(%DateProto, "getDate");
%defineNYIProperty(%DateProto, "getUTCDate");
%defineNYIProperty(%DateProto, "getUTCDay");
%defineNYIProperty(%DateProto, "getHours");
// %defineNYIProperty(%DateProto, "getHours");
%defineNYIProperty(%DateProto, "getUTCHours");
%defineNYIProperty(%DateProto, "getMinutes");
// %defineNYIProperty(%DateProto, "getMinutes");
%defineNYIProperty(%DateProto, "getUTCMinutes");
%defineNYIProperty(%DateProto, "getSeconds");
// %defineNYIProperty(%DateProto, "getSeconds");
%defineNYIProperty(%DateProto, "getUTCSeconds");
%defineNYIProperty(%DateProto, "getMilliseconds");
%defineNYIProperty(%DateProto, "getUTCMilliseconds");
Expand Down