Fill fields inside shadow roots #397
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fairly straightforward. I just introduce a function
queryShadowRootsthat converts a single parent element into a list that contains the parent plus all shadow roots amongst its descendants. ThenqueryAllVisibleinvokes it and iterates through the results, applyingquerySelectorAllto each individual shadow root (and the original parent).I tested this and it seemed to work right away, allowing autofill to succeed on one of my sites where the login form is inside a shadow root.
I recommend viewing the diff with whitespace changes disabled.
Closes #73