Skip to content

Conversation

@ohatland
Copy link
Contributor

No description provided.

@ohatland ohatland requested a review from ramvi January 29, 2024 09:34
Copy link
Contributor

@ramvi ramvi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dritbra og spesifikk dokumentasjon — spesielt tabellene! 🤩 Har kommet med spesifiseringer og kommentarer i reviewen

- hardhat
environment:
CONTAINER_HARDHAT: http://hardhat:8545
RPC_CONTAINER: http://hardhat:8545
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Har du kjørt koden med disse endringene, slik at vi vet det fungerer?

REPORT_GAS=false
CAP_TABLE_REGISTRY_brokDev=0x8EF52e971B7Aa8f263A7C25b0F4e200709287A30
DEV_ENTERPRISE_SYSTEM_ADDRESS=0x0a665B1Bc813cAE9fcDd2Eb7E25b8E55A5F35f23 No newline at end of file
DEV_ENTERPRISE_SYSTEM_ADDRESS=0x4cCE8E0e2Ba902FE7D2D1fD894d85883E7cd720d No newline at end of file
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Har du kjørt koden med disse endringene, slik at vi vet det fungerer?

| `abis/` | ABIS files for CapTable and CapTableRegistry, ***NB: These files are generated and copy manually*** |
| `build/` | Generated files from `graph codegen && graph build`, based on the content of `subgraph.yaml` |
| `docker-compose/` | Specs for running TheGraph locally with Docker compose |
| `generated/` | Some manually generated files @jon ? |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The "build" folder contains compiled and ready-to-deploy files such as ABI files for smart contracts, necessary for deploying the subgraph.

The "generated" folder includes TypeScript types and auxiliary files generated from the smart contracts' ABI, mainly used to ensure type safety and facilitate a smoother development experience when working with GraphQL queries or smart contract interactions.

| `generated/` | Some manually generated files @jon ? |
| `podman-compose/` | Specs for running TheGraph locally with Podman compose
| `scripts/` | Takes constant variables from `packages/captable/deployment/` and creates `subgraph.yaml` |
| `src/` | Some more files copy @jon ? |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Contains TypeScript mapping scripts that handle blockchain events, updating the subgraph's state with entities like CapTable, TokenHolder, and Balance, effectively transforming raw blockchain data into a structured, queryable format.

| `podman-compose/` | Specs for running TheGraph locally with Podman compose
| `scripts/` | Takes constant variables from `packages/captable/deployment/` and creates `subgraph.yaml` |
| `src/` | Some more files copy @jon ? |
| `tests/` | I dont know @jon ? |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Used for tracking the version and timestamp of the latest test run, aiding in test management and version control.

"deploy:localhost": "pnpm prepare:localhost && pnpm build && pnpm create:local && pnpm deploy:local",
"deploy:container-compose": "pnpm prepare:localhost && pnpm build && pnpm create:container && pnpm deploy:container",
"prepare:brokDev": "node scripts/prepare.js brokDev && pnpm build",
"prepare:brokStage": "node scripts/prepare.js brokStage && pnpm build",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Har du kjørt koden med disse endringene, slik at vi vet det fungerer?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Er ikke subgraph.yaml konfigurasjonsfilen til TheGraph? Da skal den vel ikke slettes?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants