Skip to content

Fix race condition: onDefinition returns empty before validatePerlDocument completes #180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
yakirgb wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix race condition: onDefinition returns empty before validatePerlDocument completes #180

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions server/src/server.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,8 @@ import { perlcompile, perlcritic, perlimports } from "./diagnostics";
import { cleanupTemporaryAssetPath } from "./assets";
import { getDefinition, getAvailableMods } from "./navigation";
import { getSymbols, getWorkspaceSymbols } from "./symbols";
import { NavigatorSettings, PerlDocument, PerlElem, completionElem} from "./types";
import { NavigatorSettings, PerlDocument, PerlElem, completionElem, ParseType } from "./types";
import { parseDocument } from "./parser";
import { getHover } from "./hover";
import { getCompletions, getCompletionDoc } from "./completion";
import { formatDoc, formatRange } from "./formatting";
Expand Down Expand Up @@ -434,7 +435,10 @@ connection.onDefinition(async (params) => {
let mods = availableMods.get("default");
if (!mods) mods = new Map();
if (!document) return;
if (!perlDoc) return; // navSymbols is an LRU cache, so the navigation elements will be missing if you open lots of files
// Parse on-demand if navSymbols hasn't been populated yet (race condition with validatePerlDocument)
if (!perlDoc) {
perlDoc = await parseDocument(document, ParseType.selfNavigation);
}
let locOut: Location | Location[] | undefined = await getDefinition(params, perlDoc, document, mods);
return locOut;
});
Expand Down