Fix clobbering of breaklist and replstring #126
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After a bit of digging after the root cause for bstansell#73, I finally fond this. This was introduced in "Imported from conserver-8.1.19.tar.gz" (b94c896) and was probably just a typo. When found bstansell#73 I saw that the same kind of "bug" happened to breaklist to so I fixed that one to. Signed-off-by: Anton Lundin <glance@ac2.se>
ppaeps
approved these changes
Oct 11, 2025
ppaeps
left a comment
ppaeps
left a comment
There was a problem hiding this comment.
I have tested this on the FreeBSD.org cluster and it works.
|
Good catch! This works for me on FreeBSD. |
netgate-git-updates
pushed a commit
to pfsense/FreeBSD-ports
that referenced
this pull request
Oct 11, 2025
Add a patch against upstream to fix tasks which substitute replstring. [1] While here, take maintainership. Obtained from: bstansell/conserver#126 [1] Approved by: eduardo (previous maintainer)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After a bit of digging after the root cause for #73, I finally fond this.
This was introduced in "Imported from conserver-8.1.19.tar.gz" (b94c896) and was probably just a typo.
When found #73 I saw that the same kind of "bug" happened to breaklist to so I fixed that one to.