Scale:circle_of_5ths_rotate+tests and ChordBuilder:extend #23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bubblesly
reviewed
Mar 24, 2025
| -- the fourth is the thirteenth | ||
| function ChordBuilder:extend(extensions) | ||
| local b = self:clone() | ||
| b.seventh = (extensions[1]==1 or extensions[1]==true) |
Owner
There was a problem hiding this comment.
Sorry I don't get why we would express boolean with either an int or an actual bool value
Contributor
Author
There was a problem hiding this comment.
The idea is to allow to pass argument array defining extensions as eg. {false,true,false,false} or {0,1,0,0} for lazy people. If it is not a canonical way to write this, I won't complain imposing strict boolean arguments.
odoare
changed the title
Contributor
Author
|
I'll make two separate PR soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.