Skip to content

Conversation

@martijndegouw
Copy link
Contributor

This allowes for easier monitoring of how much of the assigned space is used.

This allowes for easier monitoring of how much of the assigned space is
used.
@mostynb
Copy link
Collaborator

mostynb commented Oct 12, 2023

Hi, I'm not sure how useful it is to monitor this value, since you typically set it relative to the filesystem space you have available and then don't need to think about it. What's the use case for adding this?

@martijndegouw
Copy link
Contributor Author

Hi, The reason for adding it is that the bazel_remote_disk_cache_logical_bytes metric has no reference now. Monitoring does not know how much head room is left for the bazel-remote cache instance. If a more dynamic value is preferred this metric could be changed to bazel_remote_disk_cache_logical_bytes_free for example.

@ulrfa
Copy link
Contributor

ulrfa commented Oct 13, 2023

See also 8196189 from #696 that introduces bazel_remote_disk_cache_size_bytes_limit with the labels "evict" and "reject".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants