Skip to content

Conversation

@mrexodia
Copy link
Contributor

No description provided.

Copilot AI review requested due to automatic review settings December 20, 2025 12:51
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request upgrades the toml11 library from version 3.6.0 to version 4.5.0 to support TOML 1.1.0 specification features. The upgrade involves removing all the old version 3.6.0 source files and adding the new version's files.

  • Updates third-party dependency from toml11-3.6.0 to toml11-4.5.0
  • Adds test infrastructure to validate TOML 1.1.0 features
  • Includes tests for trailing commas in inline tables, newlines in inline tables, and escape sequences

Reviewed changes

Copilot reviewed 26 out of 28 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
third_party/toml11-4.5.0/LICENSE Added MIT license file for the new toml11 version
third_party/toml11-3.6.0/* Removed all source files from the old version (value.hpp, utility.hpp, types.hpp, traits.hpp, string.hpp, storage.hpp, source_location.hpp, serializer.hpp, result.hpp, region.hpp, parser.hpp, literal.hpp, lexer.hpp, into.hpp, get.hpp, from.hpp, exception.hpp, color.hpp, toml.hpp)
third_party/CMakeLists.txt Updated include directory from toml11-3.6.0 to toml11-4.5.0
tests/toml11-test/src/main.cpp Added minimal test executable entry point
tests/toml11-test/cmake.toml Added test file demonstrating TOML 1.1.0 features including trailing commas and escape sequences

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines 20 to 22
# Test escape sequence \e (TOML 1.1.0 feature)
[variables]
escape-test = "Hello\eWorld"
Copy link

Copilot AI Dec 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The escape sequence \e is being used to test TOML 1.1.0 features, but this is not a valid TOML 1.1.0 escape sequence. According to the TOML 1.1.0 specification, the valid escape sequences are: \b, \t, \n, \f, \r, ", \, \xHH (where HH are hex digits), \uXXXX, and \UXXXXXXXX. The \e escape sequence (escape character) is not part of the TOML specification.

Suggested change
# Test escape sequence \e (TOML 1.1.0 feature)
[variables]
escape-test = "Hello\eWorld"
# Test hexadecimal escape sequence for ESC (TOML 1.1.0 feature)
[variables]
escape-test = "Hello\x1bWorld"

Copilot uses AI. Check for mistakes.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants