-
-
Notifications
You must be signed in to change notification settings - Fork 38
Support TOML 1.1.0 #193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Support TOML 1.1.0 #193
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This pull request upgrades the toml11 library from version 3.6.0 to version 4.5.0 to support TOML 1.1.0 specification features. The upgrade involves removing all the old version 3.6.0 source files and adding the new version's files.
- Updates third-party dependency from toml11-3.6.0 to toml11-4.5.0
- Adds test infrastructure to validate TOML 1.1.0 features
- Includes tests for trailing commas in inline tables, newlines in inline tables, and escape sequences
Reviewed changes
Copilot reviewed 26 out of 28 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| third_party/toml11-4.5.0/LICENSE | Added MIT license file for the new toml11 version |
| third_party/toml11-3.6.0/* | Removed all source files from the old version (value.hpp, utility.hpp, types.hpp, traits.hpp, string.hpp, storage.hpp, source_location.hpp, serializer.hpp, result.hpp, region.hpp, parser.hpp, literal.hpp, lexer.hpp, into.hpp, get.hpp, from.hpp, exception.hpp, color.hpp, toml.hpp) |
| third_party/CMakeLists.txt | Updated include directory from toml11-3.6.0 to toml11-4.5.0 |
| tests/toml11-test/src/main.cpp | Added minimal test executable entry point |
| tests/toml11-test/cmake.toml | Added test file demonstrating TOML 1.1.0 features including trailing commas and escape sequences |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
tests/toml11-test/cmake.toml
Outdated
| # Test escape sequence \e (TOML 1.1.0 feature) | ||
| [variables] | ||
| escape-test = "Hello\eWorld" |
Copilot
AI
Dec 20, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The escape sequence \e is being used to test TOML 1.1.0 features, but this is not a valid TOML 1.1.0 escape sequence. According to the TOML 1.1.0 specification, the valid escape sequences are: \b, \t, \n, \f, \r, ", \, \xHH (where HH are hex digits), \uXXXX, and \UXXXXXXXX. The \e escape sequence (escape character) is not part of the TOML specification.
| # Test escape sequence \e (TOML 1.1.0 feature) | |
| [variables] | |
| escape-test = "Hello\eWorld" | |
| # Test hexadecimal escape sequence for ESC (TOML 1.1.0 feature) | |
| [variables] | |
| escape-test = "Hello\x1bWorld" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
d1da1e1 to
438fecc
Compare
No description provided.